Skip to content

Adding javadocs to some Domain classes#673

Merged
dapr-bot merged 3 commits into
dapr:masterfrom
pravinpushkar:update_javadocs
Jan 27, 2022
Merged

Adding javadocs to some Domain classes#673
dapr-bot merged 3 commits into
dapr:masterfrom
pravinpushkar:update_javadocs

Conversation

@pravinpushkar

@pravinpushkar pravinpushkar commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: pravinpushkar ppushkar@microsoft.com

Description

Adding missing javadocs to Domain classes

Issue reference

This PR will close: #671

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@pravinpushkar pravinpushkar requested review from a team as code owners January 18, 2022 10:37
mukundansundar
mukundansundar suggested changes Jan 24, 2022
View reviewed changes
Comment thread sdk/src/main/java/io/dapr/client/domain/DeleteStateRequest.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/GetConfigurationRequest.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/GetConfigurationRequest.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/GetConfigurationRequest.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/GetSecretRequest.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/SubscribeConfigurationRequest.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/TransactionalStateOperation.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/TransactionalStateOperation.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/TransactionalStateRequest.java Outdated
Comment thread sdk/src/main/java/io/dapr/client/domain/TransactionalStateRequest.java Outdated
@pravinpushkar
Adding javadocs to some Domain classes
ddc889c 
Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
@pravinpushkar
Fixing code coverage
a34ce72 
Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
@pravinpushkar
Incorporating review comments
4cbe0aa 
Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
@codecov

codecov Bot commented Jan 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #673 (378ac77) into master (3e5fe39) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 378ac77 differs from pull request most recent head 4cbe0aa. Consider uploading reports for the commit 4cbe0aa to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #673      +/-   ##
============================================
+ Coverage     77.49%   77.62%   +0.12%     
- Complexity      990      993       +3     
============================================
  Files            91       91              
  Lines          3128     3128              
  Branches        342      342              
============================================
+ Hits           2424     2428       +4     
+ Misses          535      534       -1     
+ Partials        169      166       -3
Impacted Files Coverage Δ
...java/io/dapr/client/domain/DeleteStateRequest.java 100.00% <ø> (ø)
.../client/domain/ExecuteStateTransactionRequest.java 100.00% <ø> (ø)
...va/io/dapr/client/domain/GetBulkSecretRequest.java 100.00% <ø> (ø)
...ava/io/dapr/client/domain/GetBulkStateRequest.java 94.11% <ø> (ø)
...io/dapr/client/domain/GetConfigurationRequest.java 88.88% <ø> (+11.11%) ⬆️
...n/java/io/dapr/client/domain/GetSecretRequest.java 100.00% <ø> (ø)
...in/java/io/dapr/client/domain/GetStateRequest.java 100.00% <ø> (ø)
...va/io/dapr/client/domain/InvokeBindingRequest.java 100.00% <ø> (ø)
...ava/io/dapr/client/domain/InvokeMethodRequest.java 100.00% <ø> (ø)
...n/java/io/dapr/client/domain/SaveStateRequest.java 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5fe39...4cbe0aa. Read the comment docs.

@dapr-bot dapr-bot merged commit 9989832 into dapr:master Jan 27, 2022
@pravinpushkar pravinpushkar mentioned this pull request Feb 2, 2022
Closed
4 tasks
fackee pushed a commit to fackee/java-sdk that referenced this pull request Feb 7, 2022
@pravinpushkar
Adding javadocs to some Domain classes (dapr#673)
5a82867 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 17, 2022
@pravinpushkar
Adding javadocs to some Domain classes (dapr#673)
6c3eebb 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
subash89 pushed a commit to subash89/java-sdk that referenced this pull request Mar 18, 2022
@pravinpushkar @subashfmr
Adding javadocs to some Domain classes (dapr#673)
e75ff26 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: Subash Gamage <subash.hewawidanagamage@fmr.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@pravinpushkar
Adding javadocs to some Domain classes (dapr#673)
2efe309 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@pravinpushkar
Adding javadocs to some Domain classes (dapr#673)
8713700 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@pravinpushkar
Adding javadocs to some Domain classes (dapr#673)
04a3b60 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@pravinpushkar
Adding javadocs to some Domain classes (dapr#673)
3bac6fd 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@pravinpushkar
Adding javadocs to some Domain classes (dapr#673)
a39034b 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
artursouza pushed a commit to pkedy/java-sdk that referenced this pull request Jun 22, 2022
@pravinpushkar @artursouza
Adding javadocs to some Domain classes (dapr#673)
7e40c24 
* Adding javadocs to some Domain classes

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Fixing code coverage

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

* Incorporating review comments

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mukundansundar mukundansundar mukundansundar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add java docs to io.dapr.client.domain

3 participants

@pravinpushkar @mukundansundar @dapr-bot